Merged
Conversation
giograno
approved these changes
Feb 25, 2026
Member
giograno
left a comment
giograno
left a comment
There was a problem hiding this comment.
Awesome, thanks for catching this! 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using the new wrapped records, I fell upon the following case : field: str | list[str]. Because we now wrapped such list in records, we need to add the Runtime Type to make sure we can serialize this type properly, and deserialize it back (understand it is a wrapped record when reading it)
This adds it to the schema so the serde logic can make use of it 👍
note: the weird order is because of this linting issue: https://github.com/localstack/py-avro-schema/actions/runs/22366726525/job/64734602358
Not sure if we need to configure mypy to be less strict, but it wouldn't let me call
appendon thefieldsvalue of the dict 🤷